As far as I can tell, your code should work, but it's not very Perlish. You can easily lose the loop control variable there and clarify the happenings. chomp can remove the end-of-lines on an entire list at once. join is ideal for concatenating a list of strings. In all, I'd write this like so:
use constant PER_LINE => 20; my @out; do { @out = (); while(<FILE>) { push @out, $_; last if not 1 .. PER_LINE; } chomp @out; print PIPE join ",", @out; print PIPE "\n" if @out; } until @out != PER_LINE;

See Mark-Jason Dominus' excellent Program Repair Shop and Red Flags article series on Perl.com for many introductory pointers on writing good code.

Update: D'oh! Fixed a tiny but nasty thinko in the code.

Makeshifts last the longest.


In reply to Re: while loop over filehandle by Aristotle
in thread while loop over filehandle by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.