sub wanted {
  return unless -f $_;
  my $old_flag = -M $_ > 180 ? 'old' : 'new';
  $ages{$File::Find::dir}{$old_flag}++;
}

[download]
Likely this is in a little script and I'd have no
complaint with its expeditious style. Something of the
thank-goodness-I-got-it-to-work style with which I am quite
familiar.

There is certainly a trap of believing variable names.
Like believing the documentation.

This looks like code that was refactored because the
routine name also seems to reflect a time when the author
was going to use a boolean return here and effect his count
elsewhere.

If this was part of a larger body of code...
My first concerns, assuming it does what is wanted, are:

The $old_flag might make my list, a meaningless name like
$var seems better. But it is an issue for only two lines.

I would consider inlining: 

# untested
if ( -f $file) {
   $age{$File::Find::dir}{ -M $file < 180 ? 'old' : 'new' }++;
}

[download]

In reply to Re: Re: Variable Naming by rir
in thread Tact and the Monastery by FoxtrotUniform

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.