Hi Peeps,

I have wrote the code below to pick up files in the /var/log/accounts directory and put them into variables to that i can mess around with them. It seems to work fine, but i would like to impliment Tainting on this script, and it doesn't seem to work.

If anybody has a better, cleaner and taintable way of doing what i am trying to do, PLEASE HELP ME!! 
#! /usr/bin/perl -wT

use strict;
use warnings;

# grab details from files

my ($file, $account);
my @file = `ls /var/log/accounts/`;
foreach $file (@file) {
  chomp  $file;
  $file = "/var/log/accounts/$file";
  open(FILE, "<$file") || die;
  my @account=<FILE>;
  close(FILE);
  foreach $account (@account) {
  chomp $account;
my ($fullname,$username,$password,$domain,$service,$email,$updates,$ip
+addr) = split(/,/, $account);

[download]
Thanks

In reply to Getting To Grips With Taint - And Picking Up Files by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.