I would rewrite this. Here's one way:

#! /usr/bin/perl -wT 
use strict; 
use warnings; 

my $dir = 'var/log/accounts';


opendir DIR, $dir or die "Cannot opendir $dir:$!\n"; 
my @files = grep !/^\.{1,2}$/,readdir DIR;
closedir DIR;

for (@files) 
{
    my $file = "$dir/$_";    
    open IN,$file or die "Cannot open $file:$!\n";
    while (<IN>)
    {
        next if not /,/;
        my ($fullname,$username,$password,$domain,$service,$email,$upd
+ates,$ip_addr) = split(/,/, $_);
      next if not $ip_addr;
        print "$fullname\t$username\t$password\t$domain\t$service\t$em
+ail\t$updates\t$ip_addr\n";
    }
    close IN;
}

[download]

-- Regards,
Helgi Briem
helgi AT decode DOT is

In reply to Re: Getting To Grips With Taint - And Picking Up Files by helgi
in thread Getting To Grips With Taint - And Picking Up Files by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.