Well, here's a little bit of golf right off the bat. Since we are checking the input, we can get away with an eval without fear:
#!/usr/bin/perl -w
use strict;
my @stack = ();
my %ops = ( '+' => \&calc, '-' => \&calc,
'*' => \&calc, '/' => \&calc,
'p' => sub { print $_, "\n" foreach @stack; },
'q' => sub { exit 0; }
);
while(<>) {
chomp;
if (exists $ops{$_}) {
$ops{$_}->($_);
# The badass regex is out of the Perl Cookbook, page 44
} elsif ($_ =~ /^([+-]?)(?=\d|\.\d)\d*(\.\d*)?([Ee]([+-]?\d+))?$/) {
push @stack, $_;
} else {
warn "Bad input: $_\n";
}
}
sub calc {
my $op = shift;
my $rhs = pop @stack;
my $lhs = pop @stack;
if ((! defined $lhs) || (! defined $rhs)) {
warn "Not enough values on stack!\n";
push @stack, $rhs if defined $rhs;
return undef;
}
my $res = eval $lhs.$op.$rhs;
print "$res\n";
push @stack, $res;
}
Fix: I had the rhs and lhs backwards in the eval originally
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.