In addition to what the previous person said, some shortening of your code:
@alltypes = qw(.gif .jpg .jpeg .jpe .jfif); for (1..5) { # No need for a c-style loop. if param("im$_") { ($filename = $ext = $file = param("im$_")) =~ s/.*[\/\\]//; # +Simultaneous copy/substitute. $ext =~ s/^[^.]*(\.[\w]+$)/$1/; # There are better ways to chec +k for a file, like grepping to make sure the file *ends* in the right + extension, and getting rid of $ext, IMHO, unless you're using the ex +tension somewhere...? unless (grep {$ext eq $_} @alltypes) { error("Your image needs to be a GIF of JPEG file!"); } } }

Gyan Kapur
gyan.kapur@rhhllp.com

In reply to Re: Checking File Types by Revelation
in thread Checking File Types by andrew

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.