It is difficult to decipher exactly what you are trying to do from your description and code. If I understand, then the code below should work. It is most definitely not how I would normally write such a routine but I didn't want to put too much time in as I wasn't even sure it would do what you wanted. So, I used backticks with cat (as you did), slurped in all of the files, and used a minimal amount of error checking.

It'll take the file names given on the command line and create new files with "new_" prepended to the original names that contain the contents of the file sandwiched between the contents of the files header.txt and footer.txt.

#!/usr/bin/perl -w 
use strict;

sub add_header_and_footer_to_files { 
    my @files = @_; 
    my $header = `cat header.txt`;
    my $footer = `cat footer.txt`;
    for my $filename (@files) { 
        my $file = `cat $filename`; 
        open OUT, '>', "new_$filename" 
            or die "Couldn't open $filename.new for writing: $!\n"; 
        print OUT $header, $file, $footer; 
    } 
}

add_header_and_footer_to_files(@ARGV);

[download]

Good luck!

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: special context of file names in array? by sauoq
in thread special context of file names in array? by smallaxe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.