Just a guess, but since $ENV{PATH} is already tainted, if you concatenate to $ENV{PATH}, it would still be tainted, right?

so you probably need to extract out the paths that you explicitly want, and then reassign them with the new path that you want to add

## untested, just a guess my @path; foreach my $path ( split( /:/, $ENV{PATH} ) ) { if( is_allowed_path($path) ) { ## whatever that means... push @paths, $path; } } push @paths, "/some/other/path"; $ENV{PATH} = join( ':', @paths );

Or maybe even,

delete $ENV{PATH}; $ENV{PATH} = "/path/to/tool;/some/other/path";

In reply to Re: Insecure problem by lestrrat
in thread Insecure problem by hotshot

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.