OK - if you can put your code in <CODE> tags, it's a bit easier to read, like this: 

 
#!/usr/bin/perl 
use DBI;

$user="mydb1";
$password="mydb1";

print "Content-type:text/html\n\n";

my $dbh = DBI->connect("dbi:mysql:mydb", $user, $password) or die "Can
+'t connect to $data_source: $DBI::errstr";
print "successful connection\n";

my $sth = $dbh->prepare( q{SELECT sno, name FROM IMAGE}) or die "Can't
+ prepare statement: $DBI::errstr";
my $rc = $sth->execute or die "Can't execute statement: $DBI::errstr";

print "Query will return $sth->{NUM_OF_FIELDS} fields.\n\n";
print "Field names: @{ $sth->{NAME} }\n";

while (($sno, $name) = $sth->fetchrow_array) {
    print "$name: $phone\n";
    $line="<img src=".$name;
    $line=$line." >";
    print "<img src=\"$line\">";
} 
$dbh->disconnect;
print "succefully disconnected\n"; 

print "</body></html>\n";

[download]

OK, so looking at the code, here's my thoughts:

  1. first of all, I'm going to repeat this - get used to CGI.pm, it'll make your life a lot easier.
  2. use strict - will catch a lot of errors, such as no definition of $phone
  3. You've got no <body> tag.
  4. There's no <P> tags surrounding your text
  5. You're generating HTML that looks something like <img src="<img src="filename">"> in the while loop

Hey, if there's code up ^^ there ^^, don't blame me if it doesn't work.

But today you took me walking, Through a land that we have lost,
While our children sit at websites, With no access to the cost

In reply to Re: Images by sch
in thread Images by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.