You've not included the actual rename in there (which I suspect you're aware of) but the code won't work because you're match should be m/\s+/g - the \s matches whitespace rather than the /s you have. Also the s///g is slightly incorrect. A basic outline might look something like: 

#!/usr/bin/perl

my $file = '.';

opendir(DIR,$file);
@files=readdir(DIR);
close(DIR);

for(@files)
{
    if ( m/ /g) {
        my $oldfile = $_;
        s/ /_/g;
        rename $oldfile, $_;
    }
    print $_."\n";
}

[download]

Of course, you need to consider what happens if you have a conflict such as what would happen if you had 2 files called 'test file' & 'test_file' - how would you handle this?

Hey, if there's code up ^^ there ^^, don't blame me if it doesn't work.

But today you took me walking, Through a land that we have lost,
While our children sit at websites, With no access to the cost

In reply to Re: Renaming files by sch
in thread Renaming files by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.