the script is supposed to be run in a cron job to check the directory one step above itself

In fact, it checks the directory one step above the current directory of the cron process. If you need the script to start running in a specific directory, then put a 'chdir("/pathname")' at the beginning of the script.

Alternatively, just open the directory you want to open: opendir("/pathname")

Or, more simply, don't open it at all - use Perl's glob operator in your loop:

foreach my $file (</pathname/*>) { if( ($file ne "index.html") && ($file ne ".") && ($file ne "..") && ($file ne "cgi-bin") ) {$files = 1} }

Also, you might as well break out of the loop once you've set $files to 1 - it's never going to change on subsequent iterations. In fact, you don't really need a loop at all. Try this:

my @files = grep(!/^(\.\.?|index\.html|cgi-bin)$/, </pathname/*>); if(@files) { # send email }

In reply to Re: STUPID STUPID STUPID old me. by grantm
in thread STUPID STUPID STUPID old me. by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.