line 419

# bad kludge, I haven't figured out how to handle this, but 
# if the query doesn't return anything, this function fails;
    if($query =~ /SELECT/i) {
        $return_data = $sth->fetchall_arrayref();
    }
[download]

Here I'm trying to abstract some of the database implementation by creating a function that takes in a query string and an argument list and returns the results, if there are any. Unfortunatly, when I try to call fetchall_arrayref after performing a SELECT query, it dies on me. So, I make this quick hack to see if the query contains the word "select". I would like to do this better, but I'm not quite sure how.

line 230

sub update_price
{
        # get reference to hash and algorithm for updating parts.
    my ($price, $price_algo) = @_;

    #TODO lookup return values for eval
    eval $price_algo or
        die( __LINE__ . "Err: $! \n$@\n");

    return $price;
}
[download]

This is part of my design for updating the price on a sliding scale or only under certain conditions. For example, I want to update prices that are over $100 by $15 and anything under, by only $5. My solution was to eval a statement that sets the $price variable. How safe is this? I only expect people who have an account to use this, so they have access to Perl already. Also, is there any more checking I should be doing to make sure the eval statement execute properly?

line 78

    my %items = parse_input($options{u}, $parts_algo);
[download]

This last one is kind of vague, but the problem is, parse_input doesn't do anything with $parts_algo, it just passes it off to the update_price function. I was trying to come up with a better way of doing this... maybe breaking up parse_input a little, but I hadn't really thought of anything.

Other then that, please take a look at the rest of the code, and if there are any things you would change, please let me know, I'm still pretty green.

Thanks
--
Ben
"Naked I came from my mother's womb, and naked I will depart."