Your syntax is fine. I like lower case names, but perhaps that's just a matter of preference. I don't understand why you're trying to print the same cookie, twice, but it shouldn't have any effect. Here's what I used to test your code.

#!/usr/bin/perl -w
use strict;
use CGI qw/:standard/;

my $cookie = cookie(
    -NAME    => "Matrix",
    -VALUE   => "no password",
    -EXPIRES => "+2y"
);

print header(-COOKIE => $cookie, -COOKIE => $cookie);

[download]

That works just fine, even though it looks a bit strange.

Why are you storing the username and password in the cookie? Not only can someone sniff this traffic, it's vulnerable to cross-site scripting attacks and will be stored on the users computer for up to 2 years! This is a massive security hole. Even if you think that there's nothing too sensitive on your site, people tend to reuse their usernames and passwords when they can (even if you assign them, they might use them somewhere else). Thus, if an attacker gains this knowledge, you can potentially give them access too far more than just your site. Please do not use this code.

Check out my CGI course for more information about CGI security.

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to Re: Invisible Cookies by Ovid
in thread Invisible Cookies by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.