First problem is that there is a typo in the code you posted. When doing the substitution, you had for qkeys %questionlookup; instead of keys.

However, I don't think that is the real problem as your code wouldn't compile without correcting this. So that leaves a second possibility - the format of your patterns file is not quite the same as I used in my answer.

Please go back to that answer and note the comment

#! Added leading and removed trailing /'s for consistancy

I slightly modified the format of your patterns as you supplied them as this made the format more consistent which greatly simplified the regexes used for parsing them.

As I don't have access to your patterns file, I re-used the (modified) versions that you supplied for the original question in the attached code. Using this, and with the correction above, your program works fine.

I'm afraid that if your existing patterns file omits the /'s on the first tag and includes a trailing / on the end, then you wil either have to

I think that doing the former would be easier, as well as giving a more consistant format, but only you will know the scale of the problem and how easy that modification would be to do, so that decision is yours.

Code and output 

#! perl -sw
use Data::Dumper;
use strict;
local $\=$/;
=pod Note! This is a comment only!!
my %patterns;
open(PFILE, "whatpattern.txt")|| die "Cannot open whatpattern.txt file
+";
while (<PFILE>) {
    chomp;
    next unless $_;
    my @tags = split /; |:/;
    my $key = shift @tags;
    $patterns{$key} = \@tags;
}
open(TESTFILE, "alltestfile")|| die "Cannot open alltestfile";
=cut
my %patterns = (
    '/WRB1/JJ1/VBZ1/NP1/IN1/NP2'    =>    '/NP1/VBZ1(so)/JJ1 : /NP1/IN
+1/NP2/VBZ1(really)/JJ1',
    '/WP/NP1/VB1/VBN1/PP1'            =>    '/PP1/PP2/NP1(are)/VB1',
);


while(defined(my $question=<DATA>))
{
    my @qkeys = $question =~ m!(/[A-Z0-9]+)!g;
    my @qvalues = $question =~ m!(.*?)(?:/[A-Z0-9]+\s+)!g;


    my %questionlookup;
    @questionlookup{@qkeys} = @qvalues;

    my $key = join'',@qkeys;

    print $question."\n\n";
    if (my $answer = $patterns{$key})
    {

        #! You had a syntax error here--------------------v !!!!!!!!!!
+!
#!        $answer =~ s!\s*$_\s*! $questionlookup{$_} !g for qkeys %que
+stionlookup;

        $answer =~ s!\s*$_\s*! $questionlookup{$_} !g for keys %questi
+onlookup;
        $answer =~ s/\:/\n\n/g;
        print $answer;

    } else {

        print "No Match\n";

    }
}

__DATA__
How/WRB1 hot/JJ1 is/VBZ1 the core/NP1 of/IN1 the earth/NP2 ?/

[download]

Output: 

C:\test>perl -c 210275.pl
Operator or semicolon missing before %questionlookup at 210275.pl line
+ 38.
Ambiguous use of % resolved as operator % at 210275.pl line 38.
Bareword "qkeys" not allowed while "strict subs" in use at 210275.pl l
+ine 38.
Bareword "questionlookup" not allowed while "strict subs" in use at 21
+0275.pl line 38.
210275.pl had compilation errors.

C:\test>perl -c 210275.pl
210275.pl syntax OK

C:\test>210275
How/WRB1 hot/JJ1 is/VBZ1 the core/NP1 of/IN1 the earth/NP2 ?/



 the core is (so) hot

 the core of the earth is (really) hot

C:\test>

[download]
Nah! Your thinking of Simon Templar, originally played by Roger Moore and later by Ian Ogilvy

In reply to Re: Re: Re: Re: Re: Match key and return value in some order by BrowserUk
in thread Match key and return value in some order by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.