Just a quick note about reading from files. You can iterate through the array directly without the need for a separate looping and counter variable:
foreach (sort @list)
{
my ($one, $nochop) = split(/\|/, $_);
chomp($one); # Remove any trailing linefeeds
print "<option value='$one'>$one</option>";
}
I'm not sure what your $nochop variable is for, since it doesn't seem to be utilized. Further, you're closing FILE twice, which is irregular considering the first is sufficient.
I'd also like to throw in my obligatory nitpick about using ampersands in function calls. The first line could be sufficiently written as:
unless (open(FILE, "$catdir/categories.dat"))
{
error_message("Can't find data file - $catdir/categories.dat");
}
Usually, I would put a
return call in the
unless block because there's little point in displaying a page if there's no data to put in it.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.