It's very good to see you using CGI.pm and strict with warnings. That's a good start for a beginner programmer. ++ for that.

Your coding style is good, however, why did you roll your own form-mailer? For security's sake, you should use something tried and true, like the fine scripts at nms. They worked out any potential problems you might come across.

For some information about security, check out Chapter 8: Security in the Mouse book, CGI Programming with Perl.

I'm no professional like merlyn, chromatic or any of the other fine monks here, but I can safely say that you seem to have a strong grasp of the basics of programming. It's a good start, so keep at it.

John J Reiser
newrisedesigns.com

In reply to Re: (nrd) Insecurities in my scripting by newrisedesigns
in thread Insecurities in my scripting by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.