Not bad, but there's a couple things I'd do slightly different, in the interest of scalability. Also, assigning to arrays outside the sub from inside the sub couples your routine too tightly to this particular program. Here's my version:

use diagnostics; use strict; use warnings; use Data::Dumper ; my @randomParameters = ('Abc.123', '../../', 'a@b.c', '789'); my @allowedSymbols = ('.', '@'); my (@goodParams, @badParams); my @results = checkParam( \@randomParameters, ALPHA => 1, NUMERIC => 1, SYMBOLS => \@allowedSymbols ) ; print Dumper \@results ; sub checkParam { my ( $param_list, %options ) = @_ ; my %chartypes = ( 'ALPHA' => '[:alpha:]', 'NUMERIC' => '[:digit:]' ) ; my $regex = '[' ; ## include the character classes. $regex .= join '' => map { $chartypes{$_} } grep { $options{$_} } keys %chartypes ; ## include the symbols. $regex .= join '' => @{$options{'SYMBOLS'}} ; $regex .= ']+' ; my $pattern = qr/^$regex$/; my @results = ([], []) ; for ( @$param_list ) { if ( $_ =~ /$pattern/ ) { push @{$results[0]}, $_ ; } else { push @{$results[1]}, $_ ; } } return @results ; }

_______________
DamnDirtyApe
Those who know that they are profound strive for clarity. Those who
would like to seem profound to the crowd strive for obscurity.
            --Friedrich Nietzsche

In reply to Re: Generating Regular Expressions by DamnDirtyApe
in thread Generating Regular Expressions by cjf-II

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.