A toy programming language I must use doesn't support user defined functions. So I'm writing a pre-processor to simulate the feature. I want to detect (and disallow) recursion. I have this solution that seems to work fine, but it feels kinda muddy. Can anyone offer a different approach or a refinement? Function calls won't get too deep so I don't expect speed or memory usage to become a problem.

YuckYuckFoo 

#!/usr/bin/perl

   use strict;

   my %donts;
   my %calls;

   while (chomp (my $line = <DATA>)) {

      my ($mom, $kid) = split(' ', $line);
   
      # First time moms
      if (!defined($calls{$mom})) {
         $calls{$mom} = {};
      }

      $calls{$mom}->{$kid}++;
      print "$mom calls $kid\n";

      # First time kids
      if (!defined($donts{$kid})) {

         $donts{$kid} = {};

         # Kids shouldn't call themselves
         $donts{$kid}->{$kid}++;
         print "$kid better not call $kid\n";
      }

      # Kids shouldn't call their mom
      $donts{$kid}->{$mom}++;

      # Kids shouldn't call their mom's moms
      for my $nono (keys(%{$donts{$mom}})) {

         $donts{$kid}->{$nono}++;
         print "$kid better not call $nono\n";

         # See if they do
         if ($calls{$kid}->{$nono}) {
            print "uh-oh\n";
            exit;
         }
      }
   }

   print "whew!\n";

__DATA__
aaa bbb
bbb ccc
bbb ddd
ccc ddd
ddd aaa
ddd eee

[download]

In reply to Detecting Recursion by YuckFoo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.