First, a note: the join operator is already reading the whole file into memory (the <FILE> is evaluated in list context, so it returns all the lines from the file), so there is no need for the while loop. You should just say:

#!/usr/bin/perl -w
use strict;

my $file = "go.txt";

print "\nOpening $file\n";

open(FILE, "< $file") || die "OLD FILE ERROR: Unable to open file: $!\
+n";
open(OUT, "> $file.new") || die"NEW FILE ERROR: Unable to create new f
+ile: $!\n";

my $data=join('',<FILE>);
[download]

Anyway, there is an error in the regexp, and one in the modifiers. The line should be:

$data =~ s/(CREATE TABLE "SO"\.")([^"]+)(.+?)(PRIMARY KEY)/$1$2$3CONSTRAINT PK_$2 $4/msg;

I changed two things:

• I changed from (.+) to (.+?), so that it matches the shortest string. Otherwise, when there are more than one "CREATE TABLE" in the file, it would match the first "CREATE" with the last "PRIMARY KEY".
• I added the g modifier, so that every match will be changed.

And, of course, then you have to print the result:

print OUT $data;

print "Closing $file\n";

close(OUT) || die "Unable to close OUT file: $!\n";
close(FILE) || die "Unable to close OLD file: $!\n";
[download]

-- 
        dakkar - Mobilis in mobile

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.