Try wrapping your code in tags.

As Ozymandias said, use strict and -w. Also, if you are going to report an error, you might want to know why the error occurred: use $! to report the error message.

I heard someone say once that you should use all caps to differentiate filehandles from other words in your code.

Why use "|| die" inside the parenthesis? Isn't it just fine outside of them?

You should also error check your 'system' call, but since 'system' returns 0 as the successful response, use && instead of ||. 

#!/usr/bin/perl -w
# untitled1.pl

use strict;

open(SHORTCUTS,"location.txt") || die"Can't open file: $!";
@file = <SHORTCUTS>;
close(SHORTCUTS) || die "Can't close file: $!";
foreach $line (@file) {
        system($line) && die "Can't execute $line: $!";
}

[download]
J. J. Horner
Linux, Perl, Apache, Stronghold, Unix
jhorner@knoxlug.org http://www.knoxlug.org/

In reply to Re: loading by jjhorner
in thread loading by elusion

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.