I am continually working on a set of modules for a system I am planning to use in the (hopefully) near future. I have come across something new that I have never given much thought to. This is not a problem I have come across, but more of a question of style and perhaps preference. In these modules, I have several subroutines that give a hash as a return value. My question to you wise and wonderful monks is whether I should return a hash or a hash reference.

To explain perfectly well, this is an example of one of my subroutines:

package Module::Name;

# require CGI, strict, constructor, all other code...

# A sub to return a [hash|hash reference] of CGI params.
sub get_params {
  my $self = shift;
  my %input;
  $input{$_} = $self->{$cgi_handle}->param($_)
      foreach $self->{$cgi_handle}->param());

  # The two possible ways of returning the hash.
  # Is there a preference (style or personal)
  # as to which one I should use?
  return %input;  # return hash
     # OR
  return \%input; # return hash reference
}

[download]

The first method of returning the hash (return %input;), would be handled as such:

my $CGI = new Module::Name;
my %INPUT = $CGI->get_params();
print $INPUT{'node'};

[download]

The second method of returning the has (return \%input;), would be handled as such:

my $CGI = new Module::Name;
my $INPUT = $CGI->get_params();
print $INPUT->{'node'};

[download]
My guess is that this is probably a completely personal preference rather than style, but I might be wrong. If it is personal preference, I'd like to know which method other perl users prefer and perhaps any reason(s) as to why. :)

In reply to Subroutines: Returning a hash vs. hash reference by mt2k

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.