These two routines are very similar. There are ways to refactor them to eliminate redundancy. My first thought was macros, but we don't really have them per se in Perl say (what a pun). How would you recode these two routines for succinctness?
sub rmtree { my ($o, $tree) = @_; eval { rmtree $tree } ; if ($@) { $o->LOG('error', "$tree: $@"); } } sub unlink { my ($o, $file) = @_; eval { unlink $file } ; if ($@) { $o->LOG('error', "$file: $@"); } }

Carter's compass: I know I'm on the right track when by deleting something, I'm adding functionality


In reply to My first thought was to build a macro... was I right? by princepawn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.