How would you recode these two routines for succinctness?

Maximizing succinctness is not always a good idea. Sure, it'll make you feel clever if you can reduce your program to the minimum number of lines. But it has a tendency to become a maintenance problem. What happens if you discover a slight difference in the way the parameters, return values, or errors are handled in the two functions? You either undo the succinctification, or you create a godawful mess of special cases. If your code is being maintained by someone else, the chance that they pick option two is far too high.

Unless there's something you aren't telling us (like each function is actually 100 lines long, or there are 100 of these functions), it seems like you'd be better off applying your hubris somewhere it'll get better returns.

In reply to Re: My first thought was to build a macro... was I right? by no_slogan
in thread My first thought was to build a macro... was I right? by princepawn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.