These two routines are very similar. There are ways to refactor them to eliminate redundancy.

Refactoring is less about making the code smaller than it is making the code more supportable. Usually the two go together, but not always. If you misplace these goals, you end up with smaller, less supportable code.

Both of your routines are succinct. The only refactoring I see that doesn't significantly reduce readability would be to add something like 

  sub LOGifError {
    my ($o, $what, $err) = @_;
    $o->LOG('error', "$what: $error") if $error;
  }

[download]
Then you can rewrite the error handling to   $o->LOGifError($tree, $@);

Or, if you want to "remove" two duplicate lines from each routine without adding a new method, rewrite 

  if ($@) {
     $o->LOG('error', "$tree: $@");
  }

[download]
to   $o->LOG('error', "$tree: $@") if $@; This latter rewrite is what I'd do.

In reply to Re: My first thought was to build a macro... was I right? by dws
in thread My first thought was to build a macro... was I right? by princepawn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.