(I smell homework, maybe... Oh well.)

There are a couple of problems with your code.

By looking at $numbers[$i+1], you're going to be reading past the end of the array... Not really a serious problem in perl, but something to keep in mind. You're also skipping element 0 in the array.

You'll also mark as highest any value that's followed by a lower number. So if @numbers is (1,0,100,0,2,0), you'll get 2 instead of 100.

You should be comparing $numbers[$i] with the highest value you've seen so far. 

# we assume numbers was set up somewhere above...
my $highest;
# we'll get undef if @numbers is empty
$highest=$numbers[0] if @numbers;
for(my $i=1; $i<@numbers; $i++) {
    if($numbers[$i]>$highest) {
        $highest=$numbers[$i];
    }
}
print $highest;

[download]

--
Mike

In reply to Re: finding highest number by RMGir
in thread finding highest number by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.