Another optimization, using eval

my @dlcopy = @dir_list ;
my @extensions = qw(zip log whatever) ;
my %matches ;

foreach my $ext (@extensions) {
  my $nonmatching = [] ;
  my $matching    = [] ;
  my $code = q|
  foreach my $file (@dlcopy) {
    push @{$file =~ /\\.|.$ext.q|$/ ? $matching : $nonmatching},$file 
+;
  }
| ;
  # warn "DEBUG:$code" ;
  eval $code ;
  if ($@) {
    die "Something went wrong: $@" ;
  } else {
    @dlcopy = @$nonmatching ;
    $matches{$ext} = $matching ;
  }
}

[download]

This one further optimizes the pattern matching, dynamically creating the inner foreach with the pattern hardcoded (and not reevaluated at each cycle). This could be a great enhancement if you are matching a number of files that is far greater than the number of extensions (since you would have a few evals and a lot of "constant" pattern matchings)

Ciao!
--bronto

# Another Perl edition of a song:
# The End, by The Beatles
END {
  $you->take($love) eq $you->make($love) ;
}

In reply to Re: Re: Best way to match items in an array by bronto
in thread Best way to match items in an array by ibanix

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.