if($opsys eq "unix"){flock(FILE, 2);}
else{binmode(FILE);}

[download]

This is a curious construct; the logic appears to be "lock the filehandle on systems described by the identifier 'unix', set binmode on the filehandle on other systems".

If you think you might need binmode, set it anyway; it's a no-op on systems that don't make the distinction. And try not to mix operations like that within an if {...} else {...}. Future maintenance programmers will not thank you for it.

Final point; don't use 'magic' numbers, as you do in flock() here, particularly if there's some likelyhood of cross-platform use. Use the constants provided by the Fcntl module instead. 

use Fcnlt qw(:flock);
open(FILE, "+<$bookfile")
  || &debug("Oops, I cannot read the bookfile $bookfile: $!");
if($opsys eq "unix"){flock(FILE, LOCK_EX) # Error-check here.}
else { # What do we do on other systems? }
binmode FILE;

[download]

In reply to Re: Text output is on one line by slife
in thread Text output is on one line by spoon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.