Quick re-write which tries to straighten out that problem others have described:
#!/usr/bin/perl
use strict;
use warnings;
use IO::Socket::INET;
my @host = qw[ 192.168.1.3 192.168.46.2 ];
my $port = 22;
foreach (@host)
{
check($_, $port);
}
sub check {
my ($ip, $port) = @_;
my $sock = IO::Socket::INET->new(
PeerAddr => $ip,
PeerPort => $port,
Proto => 'tcp',
timeout => 10,
);
if ($sock) {
print "$ip is listening on port $port\n";
return 1;
}
print "$ip is NOT listening on port $port.\n";
return;
}
Since
$sock is either defined or not, there's no real need for a
$connected variable. Likewise, in the interest of reducing global variable propagation, it's better to pass
$port explicitly.
You also don't need to quote numbers. Not that it's a huge difference, but it looks odd.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.