Note: I could have sworn I sent this in yesterday... bah.

My code edges into obfuscation? How about your double-negative return? ^^;;

++ on your modifications, but might I suggest:

#!/usr/bin/perl

use strict;
use warnings;
 
use IO::Socket::INET;
 
my @host = qw[ 192.168.0.5 66.100.167.57 ];
my $port = 22;
 
foreach (@host)
{
     check($_, $port);
     check_variation($_, $port);
     check_complication($_,$port);
}
 
sub can_connect
{
     my ($ip, $port) = @_;

     return ! !IO::Socket::INET->new(
                         PeerAddr => $ip,
                         PeerPort => $port,
                         Proto    => 'tcp',
                         timeout  => 10,
     );
}

sub check
{
     my ($ip, $port) = @_;
     my $can_connect = can_connect($ip,$port);

     print "$ip is ";
     print "NOT " unless ($can_connect);
     print "listening on port $port\n";

     return $can_connect;
}

sub check_variation
{
     # changed this so Strict doesn't complain
     my $can_connect = can_connect(my ($ip,$port) = @_);

     print "$ip is ";
     print "NOT " unless ($can_connect);
     print "listening on port $port\n";

     return $can_connect;
}

sub check_complication
{
     print "$_[0] is ".($_?"":"NOT ")."listening on port $_[1]\n" 
          and 
     return $_
          for 
     can_connect(@_);
}
[download]

When I was in high school I had a friend who believed he didn't have bad handwriting because, after all, he could read at least 85% of it. In that vein, "this isn't obfuscation!"

LAI
:eof

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.