Other people mentioned setting the Content-Type to image/gif or whatever it should be. I don't see where you are opening the file. You should explicity open the file instead of using the implicit filehandle. Your regexp doesn't do anything since you don't use $1. If you are going to parse the path, use File::Basename.

I will mention that you shouldn't read the binary file like it is a text file. You definitely should set binmode on the filehandle, otherwise you will run into problems if you ever run the program on a machine with different line endings.

You also shouldn't read the binary file by lines. Either slurp the whole file into a scalar in if you know they won't be too large. 

my $data = do { local $/ = undef; <$image_fh>; };

[download]

Or read and write the file by blocks: 

while (read($image_fh, $buffer, 4096)) {
    print $buffer;
}

[download]

In reply to Re: uploading images into cgi's by iburrell
in thread uploading images into cgi's by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.