Perhaps I'm being pedantic, but you seem to also be adding functionality along with your 'refactoring' -- the end result has different output from the original. My understanding of traditional refactoring is that the resulting code performs the identical function of the original.

So you have two knobs here: the refactoring knob and the 'do more stuff with the increased functionality, modularity, and clarity' knob. By turning both at the same time you risk introducing unknown errors that might slip by your test suite (you have a test suite, right? :)

As I said, I'm probably being overly pedantic. It's always interesting to see snapshots of code evolution, but in this case the code is evolving over at least two directions.

Matt

In reply to Re: Refactoring Redux... by mojotoad
in thread Refactoring Redux... by hsmyers

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.