You need to move the print ADDTO line inside the foreach loop - all you're doing there is sequentially opening the files one after the other.

It's not possible to open more than one file per filehandle - hence the handle is getting reassigned each time the loop iterates. This is why you get output in one file but not the others.

It's also good practice to close each file when you're done appending, even though the file will be closed when the filehandle goes out of scope.

A quick rewrite of your loop gives: 

foreach my $file (<*.txt>) {
   open  ADDTO, $file or die "Couldn't open $file for append.\n";
   print ADDTO  $txt;
   close ADDTO;
}

[download]

This should give you what you expect.

Hope that helps ..
-- Foxcub

Update: Added "or die" to the open.

In reply to Re: foreach not working as I expected by Tanalis
in thread foreach not working as I expected by ellem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.