XOR swapping of strings in perl is BAD. I think it's merlyn who refers to these things as bad memes?

The reason is that if the strings are different lengths, you get subtly "broken" results... 

my ($a,$b)=("a","bb"); 
printf("/%s/ (%d bytes) /%s/ (%d bytes)\n",$a,length($a),$b,length($b)
+);
$a^=$b^=$a^=$b;
printf("/%s/ (%d bytes) /%s/ (%d bytes)\n",$a,length($a),$b,length($b)
+);'

[download]
This results in: 
/a/ (1 bytes) /bb/ (2 bytes)
/bb/ (2 bytes) /a/ (2 bytes)

[download]
The unexpected "2 bytes" for /a/ occurs because the string is still 2 characters long, but the 2nd character is now null.

This can (and will) trip you up later, because $b ne "a", even though they print the same.
--
Mike

In reply to Re: Re: Re: swapping vars, two ways, 2 results... by RMGir
in thread swapping vars, two ways, 2 results... by Sihal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.