It is usually considered bad form to modify $_ during a map{} operation. People expect map{} to create a new list from an existing list, without modifying the existing list.

The expression can be written out clearer, more accurately, and using less intermediate memory by using the following code instead:

my %hash;
for (@array) {
    if (/^([^,]+)(?:,(.*))?$/) {
        $hash{$1} = $2;
    }
}

[download]

This also has the side effect of handling the case where the input takes the form "1009," or "1009". For "1009," the key will map to an empty string. For "1009" the key will map to the undefined value.

The regular expression removes the need for chomp() as the $ at the end of the regular expression will not swallow the "\n".

If efficiency is the true goal, the following code has the exact same effect:

my %hash;
/^([^,]+)(?:,(.*))?$/s && ($hash{$1} = $2) for @array;

[download]

If a few CPU ticks can be spared, the former is far more preferable to the latter.

In reply to Re: Re: Re: Re: Hash references and illegal octal digits by MarkM
in thread Hash references and illegal octal digits by peppiv

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.