This is the proper syntax: 
sub cleaner {
   my ( $text ) = @_;
   $text =~ s/\n/<br>/gs;
   $text =~ s/\t/ /g;
   return $text;
}

my $details = cleaner( $clean_me );

[download]
Note that function prototypes don't work in perl like in C or PHP code. You can't say sub cleaner( $dirty ) and expect the function to contain a variable called $dirty with your input parameter - you have to pull it off the magic @_ parameter array using shift or the syntax I use here.

Perl does have function prototypes of a sort, but they serve a different purpose than in other languages

Also, if you are matching newlines in your regular expression, you will need the s flag - otherwise the match will stop at the first newline. The s flag tells Perl to treat newlines like any other character, and match to the end of the string.

Update: See below for why that last piece of advice is irrelevant - thanks, jdporter!.

In reply to Re: Problem creating a function by FamousLongAgo
in thread Problem creating a function by Willman023

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.