You are chomping the line, even though you never look at anything other than the first record on the line if its not valid, then catenate a newline back to the end of it on saving it. You repeatedly open/close files for single records. Your regex has a quantifier of {9} although you already made sure only to look at the first nine characters - a double negative is more economic in that case (test for the absence of non-digit characters).

Also, you can reduce quite a lot of duplication.

my (%handle, $fh, $count);
$handle{02} = \*OUTPUT;

while(my $line = <INPUT>) {
    if(substr($_, 0, 9) !~ /\D/) {
        chomp $line;

        my $year;
        ($line, $year) = validLine($_);
        $line .= "\n";

        $count = $year ne "02" ? \$y_count : \$o_count;
        $fh = $handle{$year} || do {
            open my($newfh), ">>", $path."year$year.txt"
                or die "Cannot open file: $!\n";
            $newfh;
        };
    }
    else {
        $fh = \*DISCARD;
        $count = \$d_count;
    }
      
    ++$$count;
    print $fh $line;
}

[download]
If you post your validLine, chances are improvements to it can also be suggested.

Makeshifts last the longest.

In reply to Re^3: Formatting a large number of records by Aristotle
in thread Formatting a large number of records by elbow

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.