while (1) 
{
my @chars = ( "A" .. "Z", "a" .. "z", 0 .. 9, qw(! @ $ % ^ & *) );
if ($usedpw ne m/$pw/);
{
print "Your unique password is: $pw\n";
}
}
[download]

Well, there are a few problems.

• Work on your indentation. Two braces one on top of the other is a big obstacle to readability.
• Why do you have a ';' after the condition in your if statement? Normally an if statement is of the form

  if ( $foo == 1 )
  {
    $bar++;
  }
  [download]

  There's no semi-colon.
• Use 'ne' when comparing strings, '!=' when comparing numeric values and =~ when comparing patterns.
• Get rid of the 'm' in front of the pattern. It's not needed.
• How do you expect to get out of this endless loop if you aren't changing the thing that you're testing?
• Why aren't you using the array that you've defined inside the loop?
• The array definition doesn't change inside the loop (we call that loop-invariant) -- so you can take it outside the loop.
• How about some comments in the code, explaining what you're trying to do. Is it something to do with generating a password? What are the inputs and outputs?

--t. alex
Life is short: get busy!

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.