Ok, thanks everyone. I took out the semicolon and now the script sort of runs. I added the semicolon because I thought that using an if in a while loop would be different so I thought I'd have to terminate that line otherwise the rest of the loop wouldn't know what it's doing. I have a problem now though, the script is running but it's printing to screen an infinite times (Your password is: ). It's not giving out a password so my guess is it's having problems opening up USEDPW but it's not displaying any warnings with that.

Any suggestions?

Thanks 
#!/usr/bin/perl

use CGI::Carp 'fatalsToBrowser';
use strict;
use warnings;
use CGI;
my $query = CGI->new;

print $query->header;
my $usedpw = "logfile.txt" ;
my @chars = ( "A" .. "Z", "a" .. "z", 0 .. 9, qw(! @ $ % ^ & *) );
my $pw = join @chars[map{rand @chars} (1..17)];

# opening for reading
open(USEDPW, "< $usedpw") or die $!;
flock USEDPW, 1;
close(USEdPW);


while (1) 
{
my @chars = ( "A" .. "Z", "a" .. "z", 0 .. 9, qw(! @ $ % ^ & *) );
if ($usedpw ne m/$pw/)
{
print "Your unique password is: $pw\n";
}
}

open(USEDPW, "> $usedpw") or die $!;
flock USEDPW, 2;
print USEDPW "$pw\n";
close(USEDPW);

[download]


"Age is nothing more than an inaccurate number bestowed upon us at birth as just another means for others to judge and classify us"

sulfericacid

In reply to Re: While loops with if by sulfericacid
in thread While loops with if by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.