Hi again ;-)

In the first block I'd replace

$record->[1] = join ("_", $Map{$record->[1]}[1], $Map{$record->[1]}[0] +);
with
$record->[1] = $Map{$record->[1]}[1] . '_' . $Map{$record->[1]}[1];

In the second block I'd avoid the iteration by using join:

print DATA join(" ", @$record[0..4]), "\n";
rather than
for my $i (0 .. 4) { print DATA $record->[$i] . " "; } print DATA "\n";
or even
print DATA join(" ", @$_[0..4]), "\n" for (@Data);
that does the whole block in one line.

You can find the code I used to do the benchmarks on my scrachpad.

Hope this helps, -gjb-


In reply to Re: advice on improving performance of this code by gjb
in thread advice on improving performance of this code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.