This is my second attempt at a full rewrite of this random password generator. This script *should* open $saved to check if our password has already been used, if so it should stay in the loop until it finds one that's new.

I spent 2 full days trying to learn how to open and read files and I think I've got the hang of it so I'm assuming that's not the problem. My guess is it's the loop since I'm still fuzzy about those.

Like all my scripts, I don't get any reported errors anywhere, it just doesn't load. I get printed to screen "Your password is:" without your new password.

Since this is becoming such a hassle to get this one script to work, I'd really like to know what I'm doing wrong instead of just a fix to this. Any help would be much appreciated.

#!/usr/bin/perl
use strict;
use warnings;
use CGI;
use CGI::Carp 'fatalsToBrowser';

my $q = CGI->new;
print $q->header;

my $saved = "savedpasswords.txt";
my @chars = ( "A" .. "Z", "a" .. "z". 0 .. 9 qw( ! @ $ % ^ & *) );

open(SAVEDPW, "< $saved") or die $!;
flock(SAVEDPW, 1) or die $!;
my @stored = <SAVEDPW>;
close(SAVEDPW);

chomp(@stored);

my $pw;

# attempt at looping
unless ($_ ne @stored) {
$pw = join(@chars[map{rand @chars} (1..17)];
}

# loop is over, we have a new password
print "Your new password is: $_";

open(SAVEDPW, ">> $saved") or die $!;
flock(SAVEDPW, 2) or die $!;
print SAVEDPW "$_\n";
close(SAVEDPW);

[download]


"Age is nothing more than an inaccurate number bestowed upon us at birth as just another means for others to judge and classify us"

sulfericacid

In reply to Variable still not holding contents by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.