The bareword function call may not be a problem, if login.pl has been required before the code we see. I always use the parenthesis on function calls, though, just to make things clear.

I prefer to use the symbolic constants from Fcntl rather than the numbers, for the lock type argument to flock. It's just safer:

use Fcntl qw(:DEFAULT :flock); # from the Perl Cookbook open(FILE, ">file.log") or die "Can't open and truncate file: $!"; flock(FILE, LOCK_EX) or die "Can't obtain exclusive lock: $!"; print FILE "$a:$b:$c\n"; close FILE;
That'll clobber file.log, by the way. (if you don't want to do that, see mikfire's post here.)

The code for login.pl is similar, except it's LOCK_SH there.


In reply to (chromatic) RE: Re: flock problem by chromatic
in thread flock problem by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.