Ah yes! Good catch graff. The big problem, as you noted was that I was parsing the whole text. Simply adding another
last after the
chop(...) fixes that. The other was splitting on one space -- normalizing whitespace like you've done fixes that. Lastly, calling return text all those times is really bad like you've noted, so i just assigned it to a var (and used
as_is). Now, while i still like yours better, here's an updated version of mine :)
while ( my $token = $p->get_token ) {
if ($token->is_text) {
my $text = $token->as_is;
$text =~ s/\s+/ /g;
if (length($text) + $total <= 200) {
$doc2 .= $text;
$total += length($text);
}
else {
for (split / /, $text) {
if ($total + length($_) <= 200) {
$doc2 .= $_ . ' ';
$total += length($_) + 1;
}
else {
last;
}
}
chop($doc2) if $doc2 =~ /\s$/;
last;
}
}
else {
$doc2 .= $token->as_is;
}
}
Thanks for the feedback!
Minor fix to yours:
$doc2 .= substr( $tkntext, 0, rindex( $tkntext, ' ', $maxlen );
Should be:
$doc2 .= substr( $tkntext, 0, rindex( $tkntext, ' ', $maxlen ) );
it was missing a bracket. =)
--
"
To err is human, but to really foul things up you need a computer." --Paul Ehrlich
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.