Looks good!

The reason the old code seemed to hang is probably because of the way the for loop made things happen;

The 'keys' at the loop initializer extracted 2300+ keys from a hash. That's hefty operation 1.

Then 2300+ times, you extract a single entry from the hash with the key you named (hefty op 2), and perform a substitution regex with match variabels like $1/$2 (hefty op 3).

And you store it in a stringus humangeous. (Hefty op 4).

Now you're doing it nice and and gentle, one line at a time... :)

About the while instead of foreach; the 'each' operator is a very gentle way to handle hashes, because it just traverses the hash instead of performing an operation which involves the entire thing. And you can use it to get the key and value in one swoop. It might not look as 'english' as the foreach construct, but it's worth it!

Anyway, glad I could help... Happy coding!

In reply to Re: Re: Re: script hangs up when reading in file by Gilimanjaro
in thread script hangs up when reading in file by tombmbdil

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.