This is significantly faster than using eval:

sub count
{
        my ($string, $char) = @_;
        my $index = -1;
        my $count = -1;
        do {
                $count++;
                $index = index($string, $char, $index + 1);
        } while ($index != -1);
        return $count;
}

[download]

And this is faster still: 

sub count
{
        my ($string, $char) = @_;
        $string =~ s/[^$char]//g;
        return length($string);
}

[download]

        Eval: 56 wallclock secs (45.19 usr +  0.00 sys = 45.19 CPU) @ 
+3319.32/s (n=150000)
  While Loop:  5 wallclock secs ( 4.69 usr +  0.00 sys =  4.69 CPU) @ 
+31982.94/s (n=150000)
Substitution:  1 wallclock secs ( 1.41 usr +  0.00 sys =  1.41 CPU) @ 
+106382.98/s (n=150000)

[download]

Update (7/19/00): Oh, duh. s/// returns a count of the number of changes made. Here's a faster way to write the subroutine: 

sub count
{
    my ($string, $char) = @_;
    return ($string =~ s/$char//g);
}

[download]

- Matt

In reply to RE: Re: Using variables with tr/// by DrManhattan
in thread Using variables with tr/// by greenhorn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.