Your superfluous definition of
isDefined makes the code quite hard to read, and the prototype on a method is silly since method dispatch never checks them, but here's what I fiddled it apart to, with a bit of guessing:
sub interpolateValues {
return unless defined $INTWeb::Properties::INTERPOLATE_VALUES;
my $self = shift;
my $list = shift;
my $get_value_for = sub {
my $var = shift;
# !!!
# the following doesn't seem right
# don't you need to return $list->{var}
# if ->{Resolved}->{var} is undef?
# that seems to be your culprit
return $self->{Resolved}->{$var}
if defined $list->{$var}
or defined $self->{Resolved}->{$var};
die "FATAL: $var is not a valid propery variable name\n";
};
while(my($key, $val) = each %$list) {
if($val =~ s/\$\{(.*?)\}/$get_value_for->($1)/ge) {
# ???
# you don't seem to be storing this anywhere?
}
else {
$self->{Resolved}->{$key} = $val;
delete $list->{$key};
}
}
}
Makeshifts last the longest.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.