Some indentation goes a long way. Excessive comments hurt more than they help. The dot in your regex is not matched literally, it's a wildcard for "(nearly) any character". You're slurping the file, which could easily lead to a lot of memory consumption on busy sites with large logfiles. Testing
$#ARGV including equality to zero means you have to pass at least two parameters, since with a single element the result will be 0 and trigger your condition.
#!/usr/bin/perl -w
use strict;
@ARGV = qw(/var/log/apache/access_log) unless @ARGV;
my %source;
while(<>) {
next unless /cmd\.exe/;
my ($ip) = /^(\S+)/;
$source{$ip}++;
}
printf "%-6s %10s\n", $source{$_}, $_ for keys %source;
printf "%15s %10s\n", "Total:", scalar keys %source;
Untested.
Makeshifts last the longest.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.