Some random things:

%EXPORT_TAGS = ( Both => [qw(&lcc_encrypt &lcc_decrypt)], Encrypt => [qw(&lcc_encrypt)], Decrypt => [qw(&lcc_decrypt)] );

Maybe you should change the Both tag into ALL. That's how many other modules export all their public functions. If you add just one other function to the module, you'll have to change the tag, possibly breaking existing code. (Of course, exporting an additionaly function can also break existing code, but still :-).

my $upper = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'; my $lower = 'abcdefghijklmnopqrstuvwxyz'; # I didn't do join('' (a..z)) because (in 5.00503) # it caused errors for some reason.
I don't see a comma in the join comment. If I do (on Perl 5.00503):

$ perl -e "print join('' (a..z))"

then I get an error, but

perl -e "print join('', (a..z))"

Gives me the expected

abcdefghijklmnopqrstuvwxyz

And for becoming less "wooly" on blessings and objects:

(The perldoc.com search function seems to be broken right now).

Arjen


In reply to Re: My First Module: LewisCarrolCode.pm by Aragorn
in thread My First Module: LewisCarrolCode.pm by Cody Pendant

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.