You should . . 
use strict;

[download]
$ref in foo() is out of scope becaue it is my'ed in bar(). When bar() returns $ref is garbage collected.

OK folks, here his code with my comments added: 

sub foo {
    ...
########## Note that $ref does not exist(it's undef) #######

    my %locations = &bar($dbh);

## Note that $ref did not get passed back from bar ##
    ... 
  
########## $ref->{'location'} is undef, but 'use strict;'
########## here would have said: "can't use undef as hash"
    my $location_text = $locations{$ref->{'location'}};
}

sub bar {

    my $dbh = shift;

    my $sql_loc = qq|SELECT * FROM ndmw_location|; 
    my $sth = $dbh->prepare($sql_loc); 
    $sth->execute or die("...");

    my %locations;

########## Note that $ref IS my'ed here ###########

    while (my $ref = $sth->fetchrow_hashref())
    {
        my $id = $ref->{'id'};
        my $location =  $ref->{'location'};
        $locations{$id} = $location;
    }

    $sth->finish;


    return %locations;
########## Note that $ref goes away here ###########

}

[download]
And finally,

If I throw all the code into one sub and not try and split it into sub-subs, it all works as expected.

Yes, it does work for him. That's beacuse $ref does not go out of scope.

Updated To make the problem/solution more clear.

In reply to Re: Passing a hash between subs by Cabrion
in thread Passing a hash between subs by wil

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.