It looks like the 'system' call you are making is using a tainted variable. So it is either going to be $project->name or $force. Have you untainted them?

I am guessing that it is probably the $force variable, which looks from the name like it probably came from a command line switch. Even though you aren't using the value of $force in the system call, any expression that uses a tainted value will itself be tainted. From the perlsec docs:

The value of an expression containing tainted data will itself be tainted, even if it is logically impossible for the tainted data to affect the value.
Also, I would rewrite the system call to something like this: 
my @params = ('-p', $project->name);
push @params, '-p' if $force;
system 'inc_seqs', @params;

[download]

If you pass a string to system, it will use a shell to parse the parameter list and execute the program. If you pass a list (or array) of switches and parameters, you skip the need for the shell, and the program is executed directly, which saves the chance of any nasty shell escapes from happening.

Read the perlsec manual and it will explain how to do the actual untainting of the variables.

In reply to Re: cgi taint trouble by cees
in thread cgi taint trouble by sabkat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.