First, you really must "use strict" and "use warnings". There is a serious bug in your script that strict would have caught for you. The $scan in: my $scan = 1; is not the same as the $scan in: if ($scan) { The latter is actually $main::scan, since the former is out of scope, so your script will never obey "-s".

Another problem: You don't test for success when you open MPCFG, and you open it without closing it. You could run out of open file handles, for one thing. Packages IO:File or FileHandle should be preferred for file handles; if you put them in my variables they close themselves.

Some of the other things I noticed are a matter of style. I would combine the print messages before "die" with the die command itself. You print both ordinary trace messages and errors to STDOUT. Since this is a system utility you might want better control over logging and message levels; see Log::Log4perl.

But please "use strict"!

In reply to Re: First Unix Admin Script - Request for Constructive Critisism by tall_man
in thread First Unix Admin Script - Request for Constructive Critisism by D.Millin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.